Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Get push userInteraction from push-notification-ios #1642

Closed
wants to merge 1 commit into from

Conversation

xvonabur
Copy link
Contributor

This PR changes userInteraction value source. According to react-native-push-notification/ios#122 push-notification-ios@^1.5.0 has built-in userInteraction parameter on native side.

@Dallas62 Dallas62 closed this Sep 14, 2020
@Dallas62
Copy link
Collaborator

Hi @xvonabur
Thanks for this PR, but this change is already planned to be released.
https://github.com/zo0r/react-native-push-notification/tree/dev

@xvonabur
Copy link
Contributor Author

@Dallas62 it's okay. Didn't notice dev branch. Are you planning to merge this change into release in near future?

@xvonabur xvonabur deleted the user_interaction branch September 14, 2020 09:57
@Dallas62
Copy link
Collaborator

I will release the change this week / week-end.
I think this change is managed by NPM / Yarn when you upgrade.

@nishanttatva
Copy link

nishanttatva commented Sep 21, 2020

@Dallas62

Hi @xvonabur
Thanks for this PR, but this change is already planned to be released.
https://github.com/zo0r/react-native-push-notification/tree/dev

Still not released?

@Dallas62
Copy link
Collaborator

You can test changes on dev branch.

Please refer to the CHANGELOG for update instructions:
https://github.com/zo0r/react-native-push-notification/blob/dev/CHANGELOG.md#unreleased

To install this version:

npm install zo0r/react-native-push-notification#dev

OR

yarn add zo0r/react-native-push-notification#dev

Make sure your build cache is cleaned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants