Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure lat/lon attrs in the xr.Dataset #28

Merged
merged 6 commits into from
Feb 12, 2024
Merged

Ensure lat/lon attrs in the xr.Dataset #28

merged 6 commits into from
Feb 12, 2024

Conversation

zmoon
Copy link
Owner

@zmoon zmoon commented Feb 10, 2024

They were lost in the apply-ufunc application.

Also, since 2024.2.0 version (released on PyPI yesterday), fastparquet supports the .attrs roundtrip.

  • update doc mentions of attr preservation, including links

Copy link

codecov bot commented Feb 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7332c02) 98.70% compared to head (60078ac) 98.70%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #28   +/-   ##
=======================================
  Coverage   98.70%   98.70%           
=======================================
  Files           4        4           
  Lines         465      465           
=======================================
  Hits          459      459           
  Misses          6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zmoon zmoon merged commit 786d41c into main Feb 12, 2024
8 checks passed
@zmoon zmoon deleted the lat-lon-attrs branch February 12, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant