Split send into send-event and send-batch #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR splits the `send` command into two specialized commands: - `send-event` sends only one event, allowing using the provided `--partition-key` option. - `send-batch` sends all events in one of multiple batches using the provided `--batch-size` option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I want better control over sending options:
--partition-keywhen sending a single event.--batch-sizewhen sending multiple events.Change description
This PR splits the
sendcommand into two specialized commands:send-eventsends only one event, allowing using the provided--partition-keyoption.send-batchsends all events in one of multiple batches using the provided--batch-sizeoption.Additional Notes
Reviewer checklist
main.README.md, if needed).CONTRIBUTING.md) and are well-formatted.