docs: Add query strings to tabs #2840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caksoylar
force-pushed
the
docs/tab-query-strings
branch
from
f0827d5 to
3db0f35
Compare
Nick-Munnich
approved these changes
Feb 25, 2025
|
For reference, I think I only skipped https://zmk.dev/docs/features/modules#examples and https://zmk.dev/docs/development/new-behavior#submitting-a-pull-request among the ones I could find. |
Nick-Munnich
pushed a commit
to Nick-Munnich/zmk
that referenced
this pull request
Feb 27, 2025
Nick-Munnich
pushed a commit
to Nick-Munnich/zmk
that referenced
this pull request
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently docusaurus tabs support query strings, which lets you persist the selected tab to the URL: https://docusaurus.io/docs/markdown-features/tabs#query-string. I think this will be useful to share links to the docs where we can point to the right tab value, so I added it in most places that tabs are used -- skipped a few that didn't seem necessary.
Note: when value of
queryStringis skipped it falls back to usinggroupId, so I preferred that whenever the latter exists.