Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(behaviors): Minor RAM usage tweaks #2839

Merged

Conversation

petejohanson
Copy link
Contributor

@petejohanson petejohanson commented Feb 25, 2025

Follow up cleanup of some config structs not marked as const.

PR check-list

  • Branch has a clean commit history
  • Additional tests are included, if changing behaviors/core code that is testable.
  • Proper Copyright + License headers added to applicable files (Generally, we stick to "The ZMK Contributors" for copyrights to help avoid churn when files get edited)
  • Pre-commit used to check formatting of files, commit messages, etc.
  • Includes any necessary documentation changes.

Follow up cleanup of some config structs not marked as const.
@Nick-Munnich
Copy link
Contributor

Couple more points in the example code in the docs which could use a const added, along with a note under the corresponding section in the docs that _config should always be const.

@petejohanson
Copy link
Contributor Author

Couple more points in the example code in the docs which could use a const added, along with a note under the corresponding section in the docs that _config should always be const.

Added the note, but I'm not seeing any other declared instances of the config data in the new behavior guide that would get updated.

Copy link
Contributor

@Nick-Munnich Nick-Munnich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, mb, I misread a bit. LGTM

@petejohanson petejohanson merged commit 2fe55c4 into zmkfirmware:main Feb 26, 2025
50 checks passed
Nick-Munnich pushed a commit to Nick-Munnich/zmk that referenced this pull request Feb 27, 2025
Follow up cleanup of some config structs not marked as const.
Nick-Munnich pushed a commit to Nick-Munnich/zmk that referenced this pull request Feb 27, 2025
Follow up cleanup of some config structs not marked as const.
benlscott added a commit to benlscott/zmk that referenced this pull request Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants