Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jetty configuration about max pending requests #21

Closed
zloster opened this issue Apr 5, 2017 · 4 comments
Closed

Jetty configuration about max pending requests #21

zloster opened this issue Apr 5, 2017 · 4 comments
Assignees
@zloster
Milestone
Results Inspections

Comments

@zloster
Copy link
Owner

zloster commented Apr 5, 2017

Currently the dropwizard performance for the simpler testcases (plaintext and json) is almost flat. That suggests that there is some serious restriction somewhere. The other jetty tests suggest that there should be better performance. Good place to start seems to be the default dropwizard config about the max request to queue before blocking the acceptor threads.

maxQueuedRequests 1024 The maximum number of requests to queue before blocking the acceptors.

http://www.dropwizard.io/1.1.0/docs/manual/configuration.html#all
@zloster zloster modified the milestones: Dropwizard JDBI implementation, BetterTimes Apr 5, 2017
@zloster zloster modified the milestones: Round 15, Better Times Jun 28, 2017
@zloster zloster self-assigned this Jan 8, 2018
@zloster
Copy link
Owner Author

zloster commented Jan 9, 2018 •
edited
Loading

The pull request is submitted. 3175 is the PR. dropwizard with MySQL should be affected - plaintext, json and the database tests.

@zloster zloster modified the milestones: Round 15, Results Inspections Jan 9, 2018
@zloster
Copy link
Owner Author

zloster commented Feb 17, 2018

There is a big problem with this change. I'll revert it - the results in JSON are half RPS than before the change.

@zloster zloster closed this as completed Feb 17, 2018
@zloster
Copy link
Owner Author

zloster commented Feb 19, 2018 •
edited
Loading

Revert submitted. The result should be checked.
Edit: there is NO run yet on the ServerCentral environment (or Azure).

@zloster zloster reopened this Feb 19, 2018
zloster pushed a commit that referenced this issue Oct 2, 2018
@michaelhixson @NateBrady23
Fix an uncaught exception during dart startup (TechEmpower#3640)
04dd98d 
Here's an example of the error output from before this change:

Unhandled exception:
Bad state: Stream was already listened to
#0      _RawServerSocket.listen (dart:io-patch/socket_patch.dart:1106)
#1      new _ForwardingStreamSubscription (dart:async/stream_pipe.dart:123)
#2      _ForwardingStream._createSubscription (dart:async/stream_pipe.dart:91)
#3      _ForwardingStream.listen (dart:async/stream_pipe.dart:86)
#4      _ServerSocket.listen (dart:io-patch/socket_patch.dart:1351)
#5      _HttpServer.listen (dart:io/http_impl.dart:2278)
#6      _startServer.<anonymous closure> (file:///server.dart:88:12)
#7      _RootZone.runUnary (dart:async/zone.dart:1371)
#8      _FutureListener.handleValue (dart:async/future_impl.dart:129)
#9      _Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:636)
#10     _Future._propagateToListeners (dart:async/future_impl.dart:665)
#11     _Future._completeWithValue (dart:async/future_impl.dart:478)
#12     Future.wait.<anonymous closure> (dart:async/future.dart:362)
#13     _RootZone.runUnary (dart:async/zone.dart:1371)
#14     _FutureListener.handleValue (dart:async/future_impl.dart:129)
#15     _Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:636)
#16     _Future._propagateToListeners (dart:async/future_impl.dart:665)
#17     _Future._completeWithValue (dart:async/future_impl.dart:478)
#18     Future.wait.<anonymous closure> (dart:async/future.dart:362)
#19     _RootZone.runUnary (dart:async/zone.dart:1371)
#20     _FutureListener.handleValue (dart:async/future_impl.dart:129)
#21     _Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:636)
#22     _Future._propagateToListeners (dart:async/future_impl.dart:665)
#23     _Future._completeWithValue (dart:async/future_impl.dart:478)
#24     _Future._asyncComplete.<anonymous closure> (dart:async/future_impl.dart:510)
#25     _microtaskLoop (dart:async/schedule_microtask.dart:41)
#26     _startMicrotaskLoop (dart:async/schedule_microtask.dart:50)
#27     _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:99)
#28     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:152)
@zloster
Copy link
Owner Author

zloster commented Oct 4, 2018

Solving this requires a lot more effort and profiling of the running application. Will wait for better days.
Eventually...

@zloster zloster closed this as completed Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zloster zloster

Labels
None yet
Projects
None yet
Milestone
Results Inspections
Development

No branches or pull requests
1 participant
@zloster