Skip to content

Commit

Permalink
move RegExp.escape from es7 to core namespace - rejected, close #…
Browse files Browse the repository at this point in the history
  • Loading branch information
zloirock committed Nov 19, 2015
1 parent 6275d89 commit d5ee778
Show file tree
Hide file tree
Showing 24 changed files with 46 additions and 63 deletions.
2 changes: 1 addition & 1 deletion build/build.ls
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,6 @@ list = <[
es7.string.pad-end
es7.string.trim-left
es7.string.trim-right
es7.regexp.escape
es7.object.get-own-property-descriptors
es7.object.values
es7.object.entries
Expand All @@ -140,6 +139,7 @@ list = <[
core.object.define
core.object.make
core.number.iterator
core.regexp.escape
core.string.escape-html
core.string.unescape-html
core.log
Expand Down
2 changes: 1 addition & 1 deletion build/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions core/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ require('../modules/core.object.classof');
require('../modules/core.object.define');
require('../modules/core.object.make');
require('../modules/core.number.iterator');
require('../modules/core.regexp.escape');
require('../modules/core.string.escape-html');
require('../modules/core.string.unescape-html');
require('../modules/core.log');
Expand Down
2 changes: 1 addition & 1 deletion es7/regexp.js → core/regexp.js
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
require('../modules/es7.regexp.escape');
require('../modules/core.regexp.escape');
module.exports = require('../modules/$.core').RegExp;
1 change: 0 additions & 1 deletion es7/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ require('../modules/es7.string.pad-start');
require('../modules/es7.string.pad-end');
require('../modules/es7.string.trim-left');
require('../modules/es7.string.trim-right');
require('../modules/es7.regexp.escape');
require('../modules/es7.object.get-own-property-descriptors');
require('../modules/es7.object.values');
require('../modules/es7.object.entries');
Expand Down
2 changes: 1 addition & 1 deletion fn/regexp/escape.js
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
require('../../modules/es7.regexp.escape');
require('../../modules/core.regexp.escape');
module.exports = require('../../modules/$.core').RegExp.escape;
2 changes: 1 addition & 1 deletion fn/regexp/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@ require('../../modules/es6.regexp.match');
require('../../modules/es6.regexp.replace');
require('../../modules/es6.regexp.search');
require('../../modules/es6.regexp.split');
require('../../modules/es7.regexp.escape');
require('../../modules/core.regexp.escape');
module.exports = require('../../modules/$.core').RegExp;
1 change: 1 addition & 0 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ require('./modules/core.object.classof');
require('./modules/core.object.define');
require('./modules/core.object.make');
require('./modules/core.number.iterator');
require('./modules/core.regexp.escape');
require('./modules/core.string.escape-html');
require('./modules/core.string.unescape-html');
require('./modules/core.log');
Expand Down
1 change: 1 addition & 0 deletions library/core/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ require('../modules/core.object.classof');
require('../modules/core.object.define');
require('../modules/core.object.make');
require('../modules/core.number.iterator');
require('../modules/core.regexp.escape');
require('../modules/core.string.escape-html');
require('../modules/core.string.unescape-html');
require('../modules/core.log');
Expand Down
2 changes: 1 addition & 1 deletion library/es7/regexp.js → library/core/regexp.js
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
require('../modules/es7.regexp.escape');
require('../modules/core.regexp.escape');
module.exports = require('../modules/$.core').RegExp;
1 change: 0 additions & 1 deletion library/es7/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ require('../modules/es7.string.pad-start');
require('../modules/es7.string.pad-end');
require('../modules/es7.string.trim-left');
require('../modules/es7.string.trim-right');
require('../modules/es7.regexp.escape');
require('../modules/es7.object.get-own-property-descriptors');
require('../modules/es7.object.values');
require('../modules/es7.object.entries');
Expand Down
2 changes: 1 addition & 1 deletion library/fn/regexp/escape.js
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
require('../../modules/es7.regexp.escape');
require('../../modules/core.regexp.escape');
module.exports = require('../../modules/$.core').RegExp.escape;
2 changes: 1 addition & 1 deletion library/fn/regexp/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@ require('../../modules/es6.regexp.match');
require('../../modules/es6.regexp.replace');
require('../../modules/es6.regexp.search');
require('../../modules/es6.regexp.split');
require('../../modules/es7.regexp.escape');
require('../../modules/core.regexp.escape');
module.exports = require('../../modules/$.core').RegExp;
1 change: 1 addition & 0 deletions library/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ require('./modules/core.object.classof');
require('./modules/core.object.define');
require('./modules/core.object.make');
require('./modules/core.number.iterator');
require('./modules/core.regexp.escape');
require('./modules/core.string.escape-html');
require('./modules/core.string.unescape-html');
require('./modules/core.log');
Expand Down
File renamed without changes.
1 change: 0 additions & 1 deletion library/shim.js
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,6 @@ require('./modules/es7.string.pad-start');
require('./modules/es7.string.pad-end');
require('./modules/es7.string.trim-left');
require('./modules/es7.string.trim-right');
require('./modules/es7.regexp.escape');
require('./modules/es7.object.get-own-property-descriptors');
require('./modules/es7.object.values');
require('./modules/es7.object.entries');
Expand Down
File renamed without changes.
1 change: 0 additions & 1 deletion shim.js
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,6 @@ require('./modules/es7.string.pad-start');
require('./modules/es7.string.pad-end');
require('./modules/es7.string.trim-left');
require('./modules/es7.string.trim-right');
require('./modules/es7.regexp.escape');
require('./modules/es7.object.get-own-property-descriptors');
require('./modules/es7.object.values');
require('./modules/es7.object.entries');
Expand Down
2 changes: 1 addition & 1 deletion tests/commonjs.ls
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,6 @@ for P in <[.. ../library]>
ok \Map of require("#P/es6")
ok \includes of require("#P/es7/array")
ok \values of require("#P/es7/object")
ok \escape of require("#P/es7/regexp")
ok \at of require("#P/es7/string")
require("#P/es7/set")
require("#P/es7/map")
Expand All @@ -191,6 +190,7 @@ for P in <[.. ../library]>
ok \part of require("#P/core/function")
ok typeof require("#P/core/log") is \function
ok \define of require("#P/core/object")
ok \escape of require("#P/core/regexp")
ok \escapeHTML of require("#P/core/string")
ok \Array of require("#P/core")
console.log 'CommonJS - OK'
17 changes: 0 additions & 17 deletions tests/es.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

28 changes: 14 additions & 14 deletions tests/library.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{module, test} = QUnit
module \ES7
module \core-js

test 'RegExp.escape' (assert)->
{escape} = core.RegExp
Expand Down
34 changes: 17 additions & 17 deletions tests/tests.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{module, test} = QUnit
module \ES7
module \core-js

test 'RegExp.escape' (assert)->
{escape} = RegExp
Expand Down

0 comments on commit d5ee778

Please sign in to comment.