fix Object.{values, entries} for this theoretical case: https://bug…

…zilla.mozilla.org/show_bug.cgi?id=1208464#c8
zloirock · Sep 25, 2015 · bd7eb29 · bd7eb29
1 parent 3685855
commit bd7eb29
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/library/modules/$.object-to-array.js b/library/modules/$.object-to-array.js
@@ -1,15 +1,15 @@
 var $         = require('./$')
+  , has       = require('./$.has')
   , toIObject = require('./$.to-iobject');
 module.exports = function(isEntries){
   return function(it){
     var O      = toIObject(it)
       , keys   = $.getKeys(O)
       , length = keys.length
       , i      = 0
-      , result = Array(length)
+      , result = []
       , key;
-    if(isEntries)while(length > i)result[i] = [key = keys[i++], O[key]];
-    else while(length > i)result[i] = O[keys[i++]];
+    while(length > i)has(O, key = keys[i++]) && result.push(isEntries ? [key, O[key]] : O[key]);
     return result;
   };
 };
diff --git a/modules/$.object-to-array.js b/modules/$.object-to-array.js
@@ -1,15 +1,15 @@
 var $         = require('./$')
+  , has       = require('./$.has')
   , toIObject = require('./$.to-iobject');
 module.exports = function(isEntries){
   return function(it){
     var O      = toIObject(it)
       , keys   = $.getKeys(O)
       , length = keys.length
       , i      = 0
-      , result = Array(length)
+      , result = []
       , key;
-    if(isEntries)while(length > i)result[i] = [key = keys[i++], O[key]];
-    else while(length > i)result[i] = O[keys[i++]];
+    while(length > i)has(O, key = keys[i++]) && result.push(isEntries ? [key, O[key]] : O[key]);
     return result;
   };
 };