prevent changing descriptor object in defineProperty wrapper

zloirock · May 13, 2015 · 7dc41f5 · 7dc41f5
1 parent a4e9e35
commit 7dc41f5
Show file tree

Hide file tree

Showing 6 changed files with 18 additions and 10 deletions.
diff --git a/library/modules/es6.symbol.js b/library/modules/es6.symbol.js
@@ -42,7 +42,7 @@ function defineProperty(it, key, D){
       it[HIDDEN][key] = true;
     } else {
       if(has(it, HIDDEN) && it[HIDDEN][key])it[HIDDEN][key] = false;
-      D.enumerable = false;
+      D = $create(D, {enumerable: desc(0, false)});
     }
   } return setDesc(it, key, D);
 }

diff --git a/modules/es6.symbol.js b/modules/es6.symbol.js
@@ -42,7 +42,7 @@ function defineProperty(it, key, D){
       it[HIDDEN][key] = true;
     } else {
       if(has(it, HIDDEN) && it[HIDDEN][key])it[HIDDEN][key] = false;
-      D.enumerable = false;
+      D = $create(D, {enumerable: desc(0, false)});
     }
   } return setDesc(it, key, D);
 }

diff --git a/tests/tests-library.js b/tests/tests-library.js
diff --git a/tests/tests-library/es6.symbol.ls b/tests/tests-library/es6.symbol.ls
@@ -69,7 +69,9 @@ if descriptors
     defineProperty O, \b, value: \b
     defineProperty O, \c, value: \c, enumerable: on
     defineProperty O, e, configurable: on, writable:on, value: \e
-    defineProperty O, f, value: \f, enumerable: on
+    desc = value: \f, enumerable: on
+    defineProperty O, f, desc
+    eq desc.enumerable, on, 'defineProperty not changes descriptor object'
     deq getOwnPropertyDescriptor(O, \a), {configurable: on, writable:on, enumerable: on, value: \a}, 'getOwnPropertyDescriptor a'
     deq getOwnPropertyDescriptor(O, \b), {configurable: no, writable:no, enumerable: no, value: \b}, 'getOwnPropertyDescriptor b'
     deq getOwnPropertyDescriptor(O, \c), {configurable: no, writable:no, enumerable: on, value: \c}, 'getOwnPropertyDescriptor c'

diff --git a/tests/tests.js b/tests/tests.js
diff --git a/tests/tests/es6.symbol.ls b/tests/tests/es6.symbol.ls
@@ -68,7 +68,9 @@ if descriptors
     defineProperty O, \b, value: \b
     defineProperty O, \c, value: \c, enumerable: on
     defineProperty O, e, configurable: on, writable:on, value: \e
-    defineProperty O, f, value: \f, enumerable: on
+    desc = value: \f, enumerable: on
+    defineProperty O, f, desc
+    eq desc.enumerable, on, 'defineProperty not changes descriptor object'
     deq getOwnPropertyDescriptor(O, \a), {configurable: on, writable:on, enumerable: on, value: \a}, 'getOwnPropertyDescriptor a'
     deq getOwnPropertyDescriptor(O, \b), {configurable: no, writable:no, enumerable: no, value: \b}, 'getOwnPropertyDescriptor b'
     deq getOwnPropertyDescriptor(O, \c), {configurable: no, writable:no, enumerable: on, value: \c}, 'getOwnPropertyDescriptor c'