Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: error bubbling #93

Merged
merged 19 commits into from
Jan 15, 2023
Merged

chore: error bubbling #93

merged 19 commits into from
Jan 15, 2023

Conversation

alexander-camuto
Copy link
Collaborator

@alexander-camuto alexander-camuto commented Jan 10, 2023

As we start building out tooling in other languages which calls this core library, we need proper error bubbling ! Note that some of the objectives below can only be partially fulfilled as some halo2 closures / function calls require a returned error of type plonk::Error so can't generically return our custom errors.

  • error bubbling up to ezkl main.rs using Box<dyn Error>
  • remove asserts and panics!() in /src/tensor and return TensorError which derives thiserror::Error.
  • remove asserts and panics!() in /src/circuit and implement CircuitError which derives thiserror::Error (partial).
  • remove asserts and panics!() in /src/graph and implement GraphError which derives thiserror::Error (partial)
  • remove asserts and panics!() in /src/pfsys and implement PysysError which derives thiserror::Error (partial)

@alexander-camuto alexander-camuto marked this pull request as ready for review January 14, 2023 15:20
@alexander-camuto alexander-camuto merged commit 16f746b into main Jan 15, 2023
@alexander-camuto alexander-camuto deleted the ac/chore-error-handling branch January 15, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants