-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: error bubbling #93
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-camuto
force-pushed
the
ac/chore-error-handling
branch
from
January 11, 2023 21:06
4539496
to
ab4778c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we start building out tooling in other languages which calls this core library, we need proper error bubbling ! Note that some of the objectives below can only be partially fulfilled as some halo2 closures / function calls require a returned error of type plonk::Error so can't generically return our custom errors.
main.rs
usingBox<dyn Error>
/src/tensor
and returnTensorError
which derivesthiserror::Error
./src/circuit
and implementCircuitError
which derivesthiserror::Error
(partial)./src/graph
and implementGraphError
which derivesthiserror::Error
(partial)/src/pfsys
and implementPysysError
which derivesthiserror::Error
(partial)