Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: logs should go to stdout not stderr #153

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

alexander-camuto
Copy link
Collaborator

@alexander-camuto alexander-camuto commented Mar 6, 2023

env_logger by default targets stderr not stdout which causes annoyances like those highlighted in #148; hindering the ability for external packages / languages to leverage the cli as a subprocess. Here we remedy this issue by removing colog, and explicitly setting the logging target to STDOUT.

Whilst we're at it this PR also introduces a number of cosmetic improvements that were desperately needed.

  • logging timestamps
  • logging metadata (the submodule it was called from).
  • pretty printing of JSON of cli command.

Resolves #148

@alexander-camuto alexander-camuto marked this pull request as ready for review March 6, 2023 10:27
@alexander-camuto alexander-camuto merged commit ec40a77 into main Mar 7, 2023
@alexander-camuto alexander-camuto deleted the ac/fix-stdout-logging branch March 7, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outputs of EZKL goes into stderr pipe instead of stdout pipe
1 participant