-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: minor adjustment to the Solidity verify() function signature and integration of Solidity verification with the CI #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntegrate Solidity verification into the CI'
weijiekoh
force-pushed
the
sol_tests_in_ci
branch
from
February 24, 2023 06:52
f7bbb94
to
6d5f8b7
Compare
alexander-camuto
changed the title
Minor adjustment to the Solidity verify() function signature and integration of Solidity verification with the CI
chore: minor adjustment to the Solidity verify() function signature and integration of Solidity verification with the CI
Feb 24, 2023
alexander-camuto
requested changes
Feb 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few small comments regarding error handling, otherwise looks perfect !
weijiekoh
force-pushed
the
sol_tests_in_ci
branch
from
February 25, 2023 04:26
5747345
to
d6abd3f
Compare
alexander-camuto
approved these changes
Feb 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two main things:
verify()
function in Solidity to:Previously, the size of
pubInputs
had to be specified. This change makes it easier for the CI tests to run as the number of inputs is not known at compile-time.The CI flow now includes verification of the generated Solidity verifiers for the models which can be verified in Solidity (the others create contracts that are too large to work).