chore: fix ci #202
Open
chore: fix ci #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zkochan Sorry to bother you, but I hope you can take a look at this PR and the rest I've sent recently around I noticed you've merged #195, but this PR allows node 12 to be tested still on packages that still supports it, and fixes the macos fail |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
engines.nodemacos-latestnow points to macos-14, it can't installed node<=14 in arm architecture. Whilemacos-13could be used instead, I figured maybe we could remove it altogether for now since it's rare for some to use them with macos, and windows/ubuntu to probably capture most case.