-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bls12-381 support #207
Conversation
Deploying mopro with Cloudflare Pages
|
This PR is ready for review. I wrote a poseidon implementation for bls and wanted to use that for the tests here but it's making incorrect proofs. I documented the issue in #208 and added a different circuit for testing bls. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good PR!
I tried on iOS simulator and it works for me
I think we can add some e2e tests
and update bindings tests
(I can help with these)
Closes #203
This PR implements zkey loading, proving, and verifying over a generic curve. We automatically detect the curve from the zkey and use the correct implementation, or error if using an unrecognized curve. Supported curves:
alt_bn128
bls12_381
We should check binary sizes when adding additional curves. It might be worth conditionally compiling the curves.
TODO: