-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wasmer 4.x support #159
wasmer 4.x support #159
Conversation
There is a good implementation example here I haven't tried either if we patched the wasmer it works for iOS |
You can also fork the latest wasmer in zkmopro and patch these lines |
29137a7
to
dbb7ffc
Compare
@vivianjeng I think this is ready for review now. I removed the singleton pattern that was caching the wasm executor because of changes in wasmer@4. There's an in memory The new wasmer also relies more on async functions so tests are async. |
I tried to run it on iOS Previously we use error: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/install_name_tool: input file: /Users/zhengyawen/Documents/GitHub/vimwitch/mopro/mopro-example-app/target/aarch64-apple-ios/release/multiplier2.dylib is not a Mach-O file Not sure if the wasmer is wrong I saw there is also a solution like https://github.com/oliveeyay/SwiftWasmer Do you know if the |
Closing in favor of #179 |
This PR bumps the
wasmer
version from 2.x to 4.x. This relies on updates to thecircom-compat
repo to support this version (implemented in the fork here).Related #151