-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update circuit paths + add a new flag #90
Conversation
@@ -68,33 +69,34 @@ template EmailVerifier(max_header_bytes, max_body_bytes, n, k) { | |||
signal shifted_bh_out[LEN_SHA_B64] <== VarShiftLeft(max_header_bytes, LEN_SHA_B64)(bh_reveal, body_hash_idx); | |||
// log(body_hash_regex.out); | |||
|
|||
if (ignore_body_hash_check != 1) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: This diff look messed up but the only change is move the whole block below under this if condition.
I don't have visibility on if this breaks the Twitter demo since we don't have e2e tests, do you mind adding a test for something quick like witness generation that allows us to ensure things like paths and inputs are formatted correctly? We don't currently have a seperate button for that in the UI but you can probably just throw a testing wit-gen only flag onto the called function! Also while we are bumping packages, we should update to circom 2.1.6 for faster array queries (might change constraint counts? i'm curious by how much). |
a2d60be
to
2199213
Compare
a0d24f6
to
4d8b2dd
Compare
4d8b2dd
to
8e22bb6
Compare
There are unit tests in both
Yea, I think we can do this in another PR. ? |
-l
flag to including necessary (node_modules
) folders.ignore_body_hash_check
flag to EmailVerifier circuit