Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: assert error when using invalid base64 chars #103

Merged
merged 1 commit into from
Sep 19, 2023
Merged

fix: assert error when using invalid base64 chars #103

merged 1 commit into from
Sep 19, 2023

Conversation

javiersuweijie
Copy link
Collaborator

@javiersuweijie javiersuweijie commented Sep 19, 2023 •
edited
Loading

Assert that input to base64lookup is within the range of valid ASCII characters.

@javiersuweijie javiersuweijie force-pushed the fix/invalid-base64-lookup branch 2 times, most recently from 961de04 to f221540 Compare September 19, 2023 03:05
@javiersuweijie javiersuweijie force-pushed the fix/invalid-base64-lookup branch from f221540 to 7be0e05 Compare September 19, 2023 03:05
@Divide-By-0
Copy link
Member

Divide-By-0 commented Sep 19, 2023 •
edited
Loading

Thanks! This is the first audit fix and should result in a bump to packages/circuits. It's not important security-wise for zk-email, since we trust the signature from the email provider anyways. However, other people using our circuits may benefit from it. Thanks for adding some base64 tests.

@Divide-By-0 Divide-By-0 merged commit 890ac2f into zkemail:main Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@javiersuweijie @Divide-By-0