Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make zkp.ts generic #150

Closed
Divide-By-0 opened this issue Dec 1, 2023 · 4 comments
Closed

Make zkp.ts generic #150

Divide-By-0 opened this issue Dec 1, 2023 · 4 comments

Comments

@Divide-By-0
Copy link
Member

export const loadURL = "https://twitter-verifier-zkeys.s3.amazonaws.com/751fae9012c8a36543f60a2d2ec528d088ed6df0/";

Make this an argument, not a hardcoded twitter verifier url.

@alvinlee001
Copy link
Contributor

Hi @Divide-By-0, can i make this an env variable? Or do u want it to be parameter arguments for the incoming functions?

@Divide-By-0
Copy link
Member Author

Hi @Divide-By-0, can i make this an env variable? Or do u want it to be parameter arguments for the incoming functions?

Both seems good! So we make it param args and when we run main server, we set it from the env.

@alvinlee001
Copy link
Contributor

alvinlee001 commented Dec 29, 2023

Hi @Divide-By-0, I am getting this error when running zkp.test.ts:

Error: Error downloading http://localhost:3000/email.zkeyb.gz after 3 retries

May i know if i need to start a dev server? Is there docs for that?
PS: I started the 'twitter-verifier-app' in port 3000, and i was pointing to it, but seems it is not the server i needed...

saleel added a commit that referenced this issue Feb 1, 2024
pass LOAD_URL as param, and put LOAD_URL into .env
@saleel saleel closed this as completed Mar 25, 2024
@saleel
Copy link
Member

saleel commented Mar 25, 2024

This is fixed in #163 and #156

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants