This repository has been archived by the owner on Jul 6, 2019. It is now read-only.
fix: spawn child processes with node without relying on the shebang. #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on #173. |
|
Added test for |
|
Did you rebase this onto latest? I see appveyor is failing |
|
A different case of needing |
|
Hmm may just be a bad travis-ci night... |
|
Ok it looks like the ci hiccup has passed and so have the tests 😋 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix the issue reported in #172 (comment) by running commands through Node in much the same way as when passed a
nodeArg, or when run in thenpxprocess. The only time it doesn't run through Node is whenexistingis falsey, in which case it will be allowed to pass through unchanged tochild.runCommandso it errors appropriately.