-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add typescript definitions #13
base: latest
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find it strange to include types but not include a test that makes sure they pass.
Conversely, I find myself feeling kind of annoyed at the idea of having to deal with these type definitions myself when changing things or adding features. Seeing as I don't use TS for anything else right now, I'm having feelings that this would end up just becoming a maintenance burden for me once your PR lands.
Cool, I'll submit it to definitelyTyped then! I'll clean up the PR so it's
just the documentation and improved test.
On Thu., Sep. 13, 2018, 1:37 a.m. Kat Marchán, ***@***.***> wrote:
***@***.**** commented on this pull request.
I find it strange to include types but not include a test that makes sure
they pass.
Conversely, I find myself feeling kind of annoyed at the idea of having to
deal with these type definitions myself when changing things or adding
features. Seeing as I don't use TS for anything else right now, I'm having
feelings that this would end up just becoming a maintenance burden for me
once your PR lands.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#13 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAuZjHFYXAsHU9-OksjRaASrB_fAUIfBks5uahlagaJpZM4WmUrB>
.
--
~ Emily Marigold Klassen
Sent over RFC 1149
|
You can use the |
Having said that, I'm sure people would update them for you in your own repo. Another option, if you're open to it, is to just convert the project to TypeScript. |
The focus of this PR is to add type definitions for typescript. Minimum typescript version supported is 3.0.0 (as figgy pudding is very fancy)
This PR adds documentation for
other
and one extra test forthis
in forEach. These changes can be split into other PRs if you want to review them separately.