Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows build. #171

Merged
merged 1 commit into from
Feb 22, 2022
Merged

Fix windows build. #171

merged 1 commit into from
Feb 22, 2022

Conversation

codito
Copy link
Contributor

@codito codito commented Feb 22, 2022

Use variadic arguments in windows implementation of CommandFromString.
Check for windows root directory while searching for notebooks, this
fixes an infinite loop during startup notebook discovery. Fixes #139.

Please note that go build -tags "fts5 icu" will require a patch from
go-sqlite3 here with a msys2/mingw64 env.

Use variadic arguments in windows implementation of `CommandFromString`.
Check for windows root directory while searching for notebooks, this
fixes an infinite loop during startup notebook discovery. Fixes zk-org#139.

Please note that `go build -tags "fts5 icu"` will require a patch from
`go-sqlite3` [here][] with a msys2/mingw64 env.

[here]: mattn/go-sqlite3#1017
Copy link
Member

@mickael-menu mickael-menu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thank you!

@mickael-menu mickael-menu merged commit 83c15cc into zk-org:main Feb 22, 2022
@dstanberry
Copy link
Contributor

dstanberry commented Mar 17, 2022

@codito can you clarify if it is possible to use zk.exe in powershell/cmd or if it is only expected to work in the mingw64 context?

I've tried using the go-for-windows binary and installing mingw64-go but for me zk.exe only works in mingw shell.
It would be nice to be able to interact with the binary in a powershell session and this is probably a noob question but is that the expected outcome?

@codito codito deleted the windows-fix branch March 17, 2022 01:00
@codito
Copy link
Contributor Author

codito commented Mar 17, 2022

@dstanberry it is possible to use zk.exe from powershell. I had to add the mingw64 bin to user PATH env variable. This was needed for go sqlite to find icu dependencies.

@dstanberry
Copy link
Contributor

That worked for me, thanks!

If this hasn't already been discussed, it could be helpful to add some documentation (even if it is unsupported) for other windows users.

Sorry for polluting this chain.

@mickael-menu
Copy link
Member

If this hasn't already been discussed, it could be helpful to add some documentation (even if it is unsupported) for other windows users.

Sure, if it's clearly stated that the Windows support is provided on a community basis. Feel free to open a PR with some documentation for Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Support for Windows
3 participants