Skip to content

Commit

Permalink
Fix incorrect HookEventType of pull request review comments (go-git…
Browse files Browse the repository at this point in the history
…ea#23650)

`HookEventType` of pull request review comments should be
`HookEventPullRequestReviewComment` but some event types are
`HookEventPullRequestComment` now.
  • Loading branch information
Zettat123 authored Mar 24, 2023
1 parent 4acf021 commit 9e04627
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion services/actions/notifier.go
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ func (n *actionsNotifier) NotifyPullRequestReview(ctx context.Context, pr *issue
case issues_model.ReviewTypeApprove:
reviewHookType = webhook_module.HookEventPullRequestReviewApproved
case issues_model.ReviewTypeComment:
reviewHookType = webhook_module.HookEventPullRequestComment
reviewHookType = webhook_module.HookEventPullRequestReviewComment
case issues_model.ReviewTypeReject:
reviewHookType = webhook_module.HookEventPullRequestReviewRejected
default:
Expand Down
4 changes: 2 additions & 2 deletions services/webhook/discord.go
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ func (d *DiscordPayload) Review(p *api.PullRequestPayload, event webhook_module.
color = greenColor
case webhook_module.HookEventPullRequestReviewRejected:
color = redColor
case webhook_module.HookEventPullRequestComment:
case webhook_module.HookEventPullRequestReviewComment:
color = greyColor
default:
color = yellowColor
Expand Down Expand Up @@ -277,7 +277,7 @@ func parseHookPullRequestEventType(event webhook_module.HookEventType) (string,
return "approved", nil
case webhook_module.HookEventPullRequestReviewRejected:
return "rejected", nil
case webhook_module.HookEventPullRequestComment:
case webhook_module.HookEventPullRequestReviewComment:
return "comment", nil

default:
Expand Down
2 changes: 1 addition & 1 deletion services/webhook/msteams.go
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ func (m *MSTeamsPayload) Review(p *api.PullRequestPayload, event webhook_module.
color = greenColor
case webhook_module.HookEventPullRequestReviewRejected:
color = redColor
case webhook_module.HookEventPullRequestComment:
case webhook_module.HookEventPullRequestReviewComment:
color = greyColor
default:
color = yellowColor
Expand Down
2 changes: 1 addition & 1 deletion services/webhook/notifier.go
Original file line number Diff line number Diff line change
Expand Up @@ -685,7 +685,7 @@ func (m *webhookNotifier) NotifyPullRequestReview(ctx context.Context, pr *issue
case issues_model.ReviewTypeApprove:
reviewHookType = webhook_module.HookEventPullRequestReviewApproved
case issues_model.ReviewTypeComment:
reviewHookType = webhook_module.HookEventPullRequestComment
reviewHookType = webhook_module.HookEventPullRequestReviewComment
case issues_model.ReviewTypeReject:
reviewHookType = webhook_module.HookEventPullRequestReviewRejected
default:
Expand Down

0 comments on commit 9e04627

Please sign in to comment.