Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add both first and last classes when there is only one page #43

Merged
merged 1 commit into from
Dec 7, 2021
Merged

Add both first and last classes when there is only one page #43

merged 1 commit into from
Dec 7, 2021

Conversation

kolbeck
Copy link
Contributor

@kolbeck kolbeck commented Dec 2, 2021

If there is only a single page, the article element created will only have the first class, not the last class.
With this change the last class will also be added, which will remove the post-after element arrow that goes down into the footer.

@janraasch janraasch self-requested a review December 7, 2021 15:33
janraasch
janraasch approved these changes Dec 7, 2021
View reviewed changes
Copy link
Collaborator

@janraasch janraasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch ⚾️ 👍. Thank you, @kolbeck 🙏.

@janraasch janraasch merged commit 99dc336 into zjedi:master Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janraasch janraasch janraasch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kolbeck @janraasch