Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolved #54 #57

Closed
wants to merge 3 commits into from
Closed

Resolved #54 #57

wants to merge 3 commits into from

Conversation

nbehier
Copy link
Contributor

@nbehier nbehier commented Dec 19, 2012

  • Add @Properties to @Model
  • Modify fixtures file
  • Tested

Resolved zircote#54
64582b7 
- Add @properties to @model
- Modify fixtures file
- Tested
@nbehier
Copy link
Contributor Author

nbehier commented Dec 19, 2012

Maybe, it would be better to create a more expected response like

/**
 * @Model(
 *   id="PetResponse",
 *   @Properties(
 *     @Property(name="status",type="int"),
 *     @Property(name="statusName",type="string"),
 *     @Property(name="pet",type="Pet"),
 *     @Property(name="tags",type="array", items="$ref:Tag")
 *   )
 * )
 */

I think it's important to keep Tags array for testing

Nicolas Béhier-Dévigne added 2 commits December 21, 2012 00:17
Resolved zircote#55
7969045 
* Create IndexedReader.php to return an array potentially with the same
class objet
* Modify fixtures file
* Tested
Fix past commit
c2491a5 
Personal config
@zircote
Copy link
Owner

zircote commented Mar 25, 2013

Merged, thank you.

@zircote zircote closed this Mar 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbehier @zircote