New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TokenScanner: fix handling of named arguments with reserved keywords #1395

Merged

DerManoMann merged 2 commits into zircote:master from Slamdunk:fix/class_named_argument

Feb 1, 2023

Contributor

Slamdunk commented Jan 19, 2023

Reserved keywords such as class are legit for named arguments.
Without this fix I get the following error:

Message: Uninitialized string offset 1

Class: ErrorException
Code: E_WARNING
File: ./vendor/zircote/swagger-php/src/Analysers/TokenScanner.php:119


          TokenScanner: fix handling of named arguments with reserved keywords

bd86cbc

Slamdunk force-pushed the fix/class_named_argument branch from 42812f3 to bd86cbc Compare

January 19, 2023 13:04


          Move fixture to the already present dedicated file

a581300

DerManoMann merged commit 75d7faa into zircote:master

Collaborator

DerManoMann commented Feb 1, 2023

Thanks @Slamdunk

Slamdunk deleted the fix/class_named_argument branch

February 13, 2023 09:55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet