Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong DocParser Exception without context #1247

Merged
merged 2 commits into from
May 24, 2022
Merged

Wrong DocParser Exception without context #1247

merged 2 commits into from
May 24, 2022

Conversation

matiaspub
Copy link
Contributor

@matiaspub matiaspub commented May 23, 2022 •
edited
Loading

Added $context param to DocParser->parse to keep context in exception.
According to:

Full path of misstype:

[Syntax Error] Expected Doctrine\Common\Annotations\DocLexer::T_CLOSE_PARENTHESIS, got 'description' in \App\Http\Controllers\Api\V1\SmsSenderNamesController->getSenderNames() in /var/www/API_public/laravel-app/app/Http/Controllers/Api/V1/SmsSenderNamesController.php on line 18:12

much better then:

[Syntax Error] Expected Doctrine\Common\Annotations\DocLexer::T_CLOSE_PARENTHESIS, got 'description' at position 132.

@matiaspub
Copy link
Contributor Author

phpstan fail fixed!

@DerManoMann DerManoMann merged commit 05e3cb2 into zircote:master May 24, 2022
@DerManoMann
Copy link
Collaborator

Thanks @matiaspub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matiaspub @DerManoMann