Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added deprecated to OperationTrait #1175

Merged
merged 2 commits into from
Mar 24, 2022
Merged

Conversation

tm1000
Copy link
Contributor

@tm1000 tm1000 commented Mar 24, 2022

While migrating my code base from Docblock annotations to Attributes I noticed that deprecated was missing from the list os supported parameters on OperationalTrait

See also: #1023 (comment)

Copy link
Collaborator

@DerManoMann DerManoMann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks.

Could I just ask you to move deprecated after externalDocs for both lines? All attributes have x and attachables as the last two parameters in the list.
For the parent constructor that would be actually after tags, I suppose.

@tm1000
Copy link
Contributor Author

tm1000 commented Mar 24, 2022

Sure I just wasn't sure if something like that would be a breaking change but it seems like the intent here is to only allow named parameters

@DerManoMann
Copy link
Collaborator

Sure I just wasn't sure if something like that would be a breaking change but it seems like the intent here is to only allow named parameters

Yeah, its purely cosmetical, but since I took care to get them all the same it hurts to see the pattern broken :)

@DerManoMann DerManoMann merged commit 3f3b551 into zircote:master Mar 24, 2022
@DerManoMann
Copy link
Collaborator

Thanks, @tm1000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants