Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a doc link to Annotation support #1133

Merged
merged 1 commit into from
Feb 21, 2022
Merged

Conversation

kkreft
Copy link
Contributor

@kkreft kkreft commented Feb 21, 2022

I'm not convinced we still promote Annotations over Attributes but dead link is not an answer.

I'm not convinced we still promote Annotations over Attributes but dead link is not an answer.
@DerManoMann DerManoMann merged commit db6a8f8 into zircote:master Feb 21, 2022
@DerManoMann
Copy link
Collaborator

Thanks @kkreft

I agree with your sentiment - lets fix the link first and then think about rewording this. I think maybe a more general statement and a link to the reference itself might be better.
We just need to keep in mind that the docs use 'to annotate' to describe the process of adding meta-data to your source, irrespective of whether that is adding annotations or attributes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants