perf: Faster cde rejection #47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Buffer the part we need to search over (last 64K of the file) so that we don't do a 4 byte read 65536 times.
Read large chunks of data at a time to dramatically cut down on syscalls. Add tests for various edge cases to validate.
…pr412 # Conflicts: # src/spec.rs
Changed `::std::u16::MAX` to just `u16::MAX`. Signed-off-by: Chris Hennick <[email protected]>
|
@caldwell Please sign your commits. |
|
I updated my branch and github is now marking them as verified. |
|
Could you please open a new one? Try squashing it into one commit and force-pushing, since some git commands will only sign the last commit of the push. |
|
Replaced by #85. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces zip-rs/zip-old#412.