Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(dev): Use the tempfile crate instead of the deprecated tempdir crate #254

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

caldwell
Copy link
Contributor

The deprecation note is here (and visible on the crates.io page).

tempfile::TempDir has a very similar interface, though not precisely a drop in.

Locally tested on debian x86_64 rustc 1.84.0-nightly (439284741 2024-10-21):

  • cargo test
  • cargo test --no-default-features
  • cargo test --all-features
  • cargo clippy --all-targets
  • cargo clippy --all-targets --no-default-features
  • cargo clippy --all-targets --all-features
  • cargo doc --no-deps¹
  • cargo doc --no-deps --no-default-features¹
  • cargo doc --no-deps --all-features¹
  • cargo fmt --check --all

Notes

  1. Had warnings unrelated to these changes.

@caldwell caldwell mentioned this pull request Oct 23, 2024
10 tasks
@Pr0methean Pr0methean enabled auto-merge November 11, 2024 21:09
@Pr0methean Pr0methean added this pull request to the merge queue Nov 19, 2024
Merged via the queue into zip-rs:master with commit de8e3d3 Nov 19, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants