fix ci error

zip-rs · Jan 16, 2025 · b90c9e2 · b90c9e2
1 parent 6ccecd0
commit b90c9e2
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 8 deletions.
diff --git a/src/read/pipelining.rs b/src/read/pipelining.rs
@@ -1,5 +1,7 @@
 //! Pipelined extraction into a filesystem directory.
 
+#![allow(clippy::needless_lifetimes)]
+#![allow(non_local_definitions)]
 #![cfg_attr(not(unix), allow(dead_code))]
 
 pub mod path_splitting {
@@ -221,14 +223,14 @@ pub mod path_splitting {
             );
         }
 
-        #[test]
-        fn lex_trie() {
-            impl DirByMode for usize {
-                fn is_dir_by_mode(&self) -> bool {
-                    false
-                }
+        impl DirByMode for usize {
+            fn is_dir_by_mode(&self) -> bool {
+                false
             }
+        }
 
+        #[test]
+        fn lex_trie() {
             assert_eq!(
                 lexicographic_entry_trie([
                     ("a/b/", 1usize),

diff --git a/src/write.rs b/src/write.rs
@@ -536,10 +536,10 @@ impl FileOptions<'_, ExtendedFileOptions> {
     /// Removes the extra data fields.
     #[must_use]
     pub fn clear_extra_data(mut self) -> Self {
-        if self.extended_options.extra_data.len() > 0 {
+        if !self.extended_options.extra_data.is_empty() {
             self.extended_options.extra_data = Arc::new(vec![]);
         }
-        if self.extended_options.central_extra_data.len() > 0 {
+        if !self.extended_options.central_extra_data.is_empty() {
             self.extended_options.central_extra_data = Arc::new(vec![]);
         }
         self