Add TestAspect.checks to allow running aspects within property-based specs #9076
Conversation
|
💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe. |
mschuwalow
force-pushed
the
check-aspect
branch
from
12dadc3 to
ba6f8f6
Compare
| * NOTE: default implementation for backward compatibility. Remove in next | ||
| * major version. | ||
| */ | ||
| def checkSampleAspect: TestAspect.CheckSampleAspect = ZIOAspect.identity |
There was a problem hiding this comment.
This guy is a bit unfortunate as it's possible to forget to forward the aspect when creating proxies like in TestAspect.scala, but it's the most backward-compatible approach I could come up with.
Suggestions welcome.
There was a problem hiding this comment.
Had this issue myself a few times.
Scala needs an annotation on methods that should always be overwritten by concrete implementations 🥲
mschuwalow
force-pushed
the
check-aspect
branch
2 times, most recently
from
9233ad1 to
ad1b1fd
Compare
mschuwalow
force-pushed
the
check-aspect
branch
from
ad1b1fd to
842f8c8
Compare
mschuwalow
changed the title
| @@ -56,23 +65,57 @@ object TestConfig { | |||
|
|
|||
| final case class Test(repeats: Int, retries: Int, samples: Int, shrinks: Int) extends TestConfig | |||
|
|
|||
| // NOTE: Additonal class for backward compatibility. Rename to `Test` and remove the old one in next major version. | |||
| final case class Test1( | |||
There was a problem hiding this comment.
Next major version won't likely be for some time. Perhaps rename this to TestV2 add a @deprecated("use TestV2", "2.1.8") annotation to Test?
| case Spec.TestCase(oldTest, annotations) => | ||
| val newTest = makeAspect.mapError(TestFailure.fail).flatMap { aspect => | ||
| testConfigWith { oldConfig => | ||
| val newConfig = new TestConfig { |
There was a problem hiding this comment.
I think we can use the TestV2 case class here instead. I don't really know why the Test case class wasn't used here but I can't think of a good reason
| val retries = old.retries | ||
| val samples = old.samples | ||
| val shrinks = old.shrinks | ||
| val repeats = n |
| val retries = n | ||
| val samples = old.samples | ||
| val shrinks = old.shrinks | ||
| val repeats = old.repeats |
| val retries = old.retries | ||
| val samples = n | ||
| val shrinks = old.shrinks | ||
| val repeats = old.repeats |
| val retries = old.retries | ||
| val samples = old.samples | ||
| val shrinks = n | ||
| val repeats = old.repeats |
mschuwalow
force-pushed
the
check-aspect
branch
2 times, most recently
from
81f0816 to
6c8879a
Compare
mschuwalow
force-pushed
the
check-aspect
branch
from
6c8879a to
a4a2787
Compare
| import zio.System.env | ||
| import zio.test.TestAspectAtLeastR | ||
| import zio.test.TestAspectAtLeastR |
resolves #9046
/claim #9046