Add Scala 2.13 support #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, just saw config.yaml. That will also have to be updated. |
|
Finally... 😅 Also, apparently there's no |
|
Looks good! I see there are a few deprecation warnings in 2.13, could you have a look? |
|
Yeah, those JavaConverters warnings come up a lot when upgrading to 2.13. I've seen many different ways of handling it. Some people just ignore them (or use the silencer plugin), while others do tedious code splitting. There's also this. And then there's |
ghostdogpr
approved these changes
Sep 29, 2019
|
All good, thanks! I’ll do a release. |
ghostdogpr
pushed a commit
to ghostdogpr/zio-sqs
that referenced
this pull request
Feb 25, 2020
* Add Scala 2.13 support * Add Scala 2.13 to config.yml * Use supported versions for docker images * Remove reference to non-existing image * Remove reference to non-existing image * Fix deprecation warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29
Disables the tests for 2.13 temporary until elasticmq supports it.
Also, I saw a reference to Scala 2.11 in
build.sbt, but it doesn't seem to actually be used (and I don't see 2.11 published), so I'm assuming that was just remnants from an old build file and it wasn't intentional.