Handle empty bulk string (#808) #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@sunLightLeaf Please fix formatting errors by running |
|
Strange. Before running |
|
@sunLightLeaf it isn't related to formatting. My guess is that they're just flaky. |
mijicd
previously approved these changes
May 30, 2023
mijicd
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #808
This did change how
getRangeworks, as it now returns empty quotes even when the sought range exceed the length of the string, but to my knowledge (tweaking around with redis-cli)getRangereturning empty quotes in such scenarios is standard redis behaviour.Hope that helps! I'm ready to tinker with this some more in case you think this solution could be improved.