Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable macro log do not print dynamic query detected #473

Merged
merged 6 commits into from
Dec 2, 2024

Conversation

patextreme
Copy link
Contributor

@patextreme patextreme commented Jul 12, 2024

Fixes #470

Problem

-Dquill.macro.log=false doesn't silence the Dynamic Query Detected ... which become quite verbose when the project start to grow.

Solution

Add the same condition to check the flag before printing the log above so it has parity with static query logs.

Notes

Additional notes.

Checklist

  • Unit test all changes
  • Update README.md if applicable
  • Add [WIP] to the pull request title if it's work in progress
  • Squash commits that aren't meaningful changes

@getquill/maintainers

@patextreme
Copy link
Contributor Author

Resolves #470

@FabioPinheiro
Copy link

Can we push this fix to be merge and release

Copy link
Collaborator

@juliano juliano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution here!

@juliano juliano merged commit 909886a into zio:master Dec 2, 2024
5 checks passed
@patextreme patextreme deleted the dynamic-query-logging branch December 10, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flag quill.macro.log does not silence logs about quill dynamic queries
3 participants