Add all the typeclasses instance for the zio.prelude.data.Optional type (copied from the Option instances)
#1415
Conversation
guizmaii
force-pushed
the
optional_instances
branch
from
46f9bf0 to
3dc9c9e
Compare
guizmaii
changed the title
IdentityBoth instance for zio.prelude.data.Optionalzio.prelude.data.Optional type (copied from the Option instances)
guizmaii
changed the title
zio.prelude.data.Optional type (copied from the Option instances)zio.prelude.data.Optional type (copied from the Option instances)
| fa match { | ||
| case Some(a) => | ||
| fb match { | ||
| case Some(b) => Some((a, b)) | ||
| case None => None | ||
| } | ||
| case None => None | ||
| } | ||
| } |
There was a problem hiding this comment.
Just optimizing the code here
| case Optional.Absent => other | ||
| } | ||
| final def orElse[B >: A](alternative: => Optional[B]): Optional[B] = | ||
| if (isEmpty) alternative else this |
There was a problem hiding this comment.
Code copied from Option#orElse. Avoids the call to the unapply function in Optional.Present(_)
| case Optional.Present(_) => self | ||
| case Optional.Absent => other | ||
| } | ||
| final def orElse[B >: A](alternative: => Optional[B]): Optional[B] = |
There was a problem hiding this comment.
The Option#orElse method is lazy
| @@ -50,7 +50,7 @@ sealed trait Optional[+A] { self => | |||
| case Optional.Absent => ifEmpty | |||
| } | |||
|
|
|||
| final def flatten[B](implicit ev: A <:< Option[B]): Option[B] = | |||
| final def flatten[B](implicit ev: A <:< Optional[B]): Optional[B] = | |||
There was a problem hiding this comment.
I didn't understand why the evidence what proving that A was an Option[B] nor why this method was returning an Option[B] and not an Optional[B].
Probably a copy/paste mistake
guizmaii
force-pushed
the
optional_instances
branch
from
c0ff1b0 to
120dcd9
Compare
guizmaii
force-pushed
the
optional_instances
branch
3 times, most recently
from
df65490 to
56c240c
Compare
guizmaii
force-pushed
the
optional_instances
branch
from
56c240c to
0d843e8
Compare
| /** | ||
| * Derives an `Equal[Optional[A]]` given an `Equal[A]`. | ||
| */ | ||
| implicit def OptionalEqual[A: Equal]: Equal[Optional[A]] = |
There was a problem hiding this comment.
@sideeffffect I didn't find the tests for this typeclass 🤔
| /** | ||
| * The [[DeriveEqual]] instance for [[Optional]]. | ||
| */ | ||
| implicit val OptionalDeriveEqual: DeriveEqual[Optional] = |
There was a problem hiding this comment.
@sideeffffect I didn't find the tests for this typeclass 🤔
|
@sideeffffect Can we make a new release maybe, please? |
|
Most definitely! https://github.com/zio/zio-prelude/releases/tag/v1.0.0-RC34 |
|
@sideeffffect Thanks for the compliments :) I think I already have these rights, I just don't feel legitimate to take these decisions by myself for now but if you tell me I can, then let's go :) |
|
Please, feel free take these decisions yourself 😉 |
@sideeffffect Did I forget any typeclass? 🤔