Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Signature of ForEach#collectM #1236

Merged
merged 2 commits into from
Jan 14, 2024
Merged

Update Signature of ForEach#collectM #1236

merged 2 commits into from
Jan 14, 2024

Conversation

adamgfraser
Copy link
Contributor

I think it is more useful if the effect can be used to determine whether to return a value.

@adamgfraser adamgfraser requested a review from a team as a code owner January 9, 2024 23:51
Copy link
Member

@sideeffffect sideeffffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If practice shows that this is better, then why not 👍

@adamgfraser adamgfraser merged commit 14d825c into zio:series/2.x Jan 14, 2024
19 checks passed
@adamgfraser adamgfraser deleted the collectm branch January 14, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants