Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CovariantIdentityBoth#forEach Implementation #1193

Merged
merged 2 commits into from
Sep 17, 2023
Merged

Fix CovariantIdentityBoth#forEach Implementation #1193

merged 2 commits into from
Sep 17, 2023

Conversation

adamgfraser
Copy link
Contributor

No description provided.

@adamgfraser adamgfraser requested a review from a team as a code owner September 16, 2023 04:35
@adamgfraser adamgfraser linked an issue Sep 16, 2023 that may be closed by this pull request
Broken forEach on CovariantIdentityBoth #1194
Closed
sideeffffect
sideeffffect approved these changes Sep 17, 2023
View reviewed changes
Copy link
Member

@sideeffffect sideeffffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but the changes to site.yaml seem accidental.

.github/workflows/site.yml Show resolved Hide resolved
@adamgfraser adamgfraser merged commit 91a27b8 into zio:series/2.x Sep 17, 2023
18 checks passed
@adamgfraser adamgfraser deleted the foreach branch September 17, 2023 12:45
@khajavi khajavi mentioned this pull request Sep 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guizmaii guizmaii guizmaii left review comments

@khajavi khajavi khajavi left review comments

@sideeffffect sideeffffect sideeffffect approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken forEach on CovariantIdentityBoth
4 participants
@adamgfraser @khajavi @guizmaii @sideeffffect