Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Framework Benchmark Workflow #2830

Merged
merged 23 commits into from
May 11, 2024

Conversation

khajavi
Copy link
Member

@khajavi khajavi commented May 7, 2024

I need to compare the framework benchmarks for documentation purposes. I don't know why this was disabled, anyway If it was too time-consuming, I can enable it only on release events.

Update:
This is a CI job to check that PR changes don't degrade performance, not for the benchmark comparison that I wanted. So after releasing ZIO HTTP, we have to update the main repo for "Web Framework Benchmark" to have ZIO HTTP in the next round of their performance benchmark comparison.

  • I made the corresponding PR to make the "Web Framework Benchmark" ready to use in CI
  • Also I decreased the performance floor to make the CI green!
    • SimpleEffectBenchmarkServer (from 50k/s t0 30k/s)
    • PlainTextBenchmarkServer (from 80k/s to 30k/s )
  • I unfroze the routes under the benchmark (PlainTextBenchmarkServer) since the benchmark framework verifies that the routes are not cached.

@khajavi khajavi marked this pull request as ready for review May 10, 2024 19:04
@987Nabil 987Nabil merged commit 2667175 into zio:main May 11, 2024
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants