Fix streaming response compression #2798
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where if a streaming response has a known size, netty fails to compress it and the response is all botched up. The main culprit is that the
ByteBuf
objects need to be wrapped in aDefaultHttpResponse
prior to writing them to the Netty channel for Netty to be able to compress them properly.In addition, there is also another minor bug where the content-length from headers is not being extracted correctly, as it seems that netty will mutate the response object after
writeAndFlush
has been invoked on it, which means we need to extract the content-length before we call itTo reproduce, run the following code and open
http://localhost:8080/foo
on a browser: