Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation of BinaryCodecs #2793

Merged
merged 8 commits into from
Apr 23, 2024
Merged

Documentation of BinaryCodecs #2793

merged 8 commits into from
Apr 23, 2024

Conversation

khajavi
Copy link
Member

@khajavi khajavi commented Apr 22, 2024

No description provided.

@khajavi khajavi marked this pull request as ready for review April 22, 2024 13:19
@khajavi
Copy link
Member Author

khajavi commented Apr 22, 2024

Before merging this PR, please merge this one: #2785

@khajavi
Copy link
Member Author

khajavi commented Apr 23, 2024

@987Nabil
Do you have any idea why the CI failed on this PR?

for {
book <- req.body.to[Book].catchAll(_ => ZIO.fail(Response.badRequest("unable to deserialize the request")))
books <- ZIO.service[Ref[List[Book]]]
_ <- books.updateAndGet(_.appended(book))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try instead _ :+ book

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Fixed!
I'm curious, what is the difference between :+ and appended?

@jdegoes jdegoes merged commit ca2937d into zio:main Apr 23, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants