Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation of Testing HTTP Applications #2774

Merged
merged 3 commits into from
Apr 22, 2024
Merged

Conversation

khajavi
Copy link
Member

@khajavi khajavi commented Apr 17, 2024

No description provided.

@@ -77,7 +77,7 @@ private[zio] final case class NettyDriver(
override def toString: String = s"NettyDriver($serverConfig)"
}

private[zio] object NettyDriver {
object NettyDriver {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review reminder: I made the NettyDriver public to make it usable for anyone who wants to utilize it when writing tests.

@khajavi khajavi marked this pull request as ready for review April 17, 2024 12:07
@khajavi
Copy link
Member Author

khajavi commented Apr 19, 2024

@jdegoes This is ready for review!

@jdegoes
Copy link
Member

jdegoes commented Apr 21, 2024

@khajavi Please fix conflicts, then good to merge. 🙏

@khajavi khajavi merged commit f2b0afa into zio:main Apr 22, 2024
25 checks passed
@khajavi khajavi deleted the testing-http-app branch April 22, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants