add scala-styled lambdas rendering #373
Conversation
|
|
| override implicit lazy val r_TypeParam: Renderable[TypeParam] = new Renderable[TypeParam] { | ||
| override def render(value: TypeParam): String = | ||
| value.ref match { | ||
| case n: NameReference if n.symName.name.forall(_.isDigit) => |
There was a problem hiding this comment.
This is a heuristic which may fail. We need to preserve the context here and check the names against it. Also we might want to add more metadata into the model to simplify the logic here but that's undesirable.
There was a problem hiding this comment.
Added LambdaParamNameMaker to hold the logic for both creating param names and checking if a string is a param name in one place. Doesn't seem to me like a clean solution but can't think of any others except extra metadata in model
Ivoyaa
force-pushed
the
wip/367-add-scala-styled-lambda-rendering
branch
from
4a1e30a
to
f4ad8ef
Compare
|
This seems to be working, though it still looks like an ad-hoc solution. I would try one of two options:
|
…a-styled-lambda-rendering # Conflicts: # izumi-reflect/izumi-reflect/src/main/scala-2/izumi/reflect/macrortti/LightTypeTagImpl.scala # izumi-reflect/izumi-reflect/src/main/scala-3/izumi/reflect/TagMacro.scala # izumi-reflect/izumi-reflect/src/main/scala/izumi/reflect/macrortti/LightTypeTagRef.scala
Ivoyaa
force-pushed
the
wip/367-add-scala-styled-lambda-rendering
branch
from
f1b25c9
to
ac508a4
Compare
Ivoyaa
force-pushed
the
wip/367-add-scala-styled-lambda-rendering
branch
from
ac508a4
to
a811bbe
Compare
| override def render(value: Boundaries): String = value match { | ||
| case Boundaries.Defined(bottom, top) => | ||
| (bottom.render(), top.render()) match { | ||
| case (bottomRendered, topRendered) if bottomRendered == "scala.Nothing" => s"<: $topRendered" |
There was a problem hiding this comment.
This is kinda dirty. We already have all the necessary constants in LightTypeTagInheritance, please reuse them.
There was a problem hiding this comment.
Yep, removed my hardcode
No description provided.