Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Automatic-Module-Name to JAR manifest #290

Merged
merged 2 commits into from
May 30, 2022
Merged

Added Automatic-Module-Name to JAR manifest #290

merged 2 commits into from
May 30, 2022

Conversation

ajaychandran
Copy link
Contributor

Fixes #289.

The module names are:

dev.zio.izumi.reflect
dev.zio.izumi.reflect.thirdparty.boopickle.shaded

All JAR artifacts passed the jdeps --jdk-internals sanity check.

@ajaychandran ajaychandran mentioned this pull request May 25, 2022
Merged
@neko-kai neko-kai enabled auto-merge (squash) May 30, 2022 19:59
@neko-kai neko-kai merged commit 7e7087f into zio:develop May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pshirshov pshirshov Awaiting requested review from pshirshov pshirshov is a code owner

@neko-kai neko-kai Awaiting requested review from neko-kai neko-kai is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add "Automatic-Module-Name" for release artifacts
2 participants
@ajaychandran @neko-kai