Fix allPartsStrong #279
Fix allPartsStrong #279
Conversation
| @@ -23,6 +25,11 @@ class TagTest extends SharedTagTest with TagAssertions { | |||
| assertNotChild(Tag[Animal | String].tag, Tag[Dog | String].tag) | |||
| } | |||
|
|
|||
| "Does not synthesize Tags for abstract types, but recursively summons" in { | |||
There was a problem hiding this comment.
This should be part of SharedTagTest I believe, to ensure the behavior is the same in Scala 2 & 3. You may also want to test against types object X; X.T, val x; x.T & trait X; X#T since they're all quite different types than this.T aand Tag does not behave uniformly wrt them all
|
Alrighty :) I've moved it to the SharedTagTest and added some additional cases |
|
Ah interesting. So two of these should fail on Scala 3. I see what you mean. I'll see if I can get that to be consistent. |
|
I think I got it! Come on CI 🤞 |
|
Once this is good to go, would it be possible to merge and release a new version? Hoping to resolve this issue (zio/zio#6546) in the next ZIO 2 RC 😄 Many thank yous! |
|
@kitlangton I think I'm going to release this fix under 2.1.0 series since it seems stable after testing and it includes your previous fix (50def11) (https://github.com/zio/izumi-reflect/releases/tag/v2.1.0-M1) |
|
Totally! Thanks so much @neko-kai |
|
Version |
|
Will do! |
@adamgfraser, @swoogles and I ran into a Tag issue with ZIO that stemmed from Tags being synthesized for abstract type members of traits, instead of being recursively summoned. This should (hopefully) fix that 😄