Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove empty laws overrides #215

Merged
merged 3 commits into from
Aug 13, 2020
Merged

Remove empty laws overrides #215

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
012064f
Remove empty laws overrides
joroKr21 Aug 12, 2020
de8792a
Merge branch 'master' into empty-overrides
ghostdogpr Aug 13, 2020
6c994b7
Merge branch 'master' into empty-overrides
ghostdogpr Aug 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 7 additions & 29 deletions interop-cats/shared/src/test/scala/zio/interop/catzSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
package zio.interop

import cats.Monad
import cats.arrow.ArrowChoice
import cats.effect.concurrent.Deferred
import cats.effect.laws._
import cats.effect.laws.discipline.arbitrary._
import cats.effect.laws.discipline.{ ConcurrentEffectTests, ConcurrentTests, EffectTests, SyncTests }
import cats.effect.laws._
import cats.effect.{ Concurrent, ConcurrentEffect, ContextShift, Effect }
import cats.implicits._
import cats.laws._
import cats.laws.discipline._
import cats.{ Monad, SemigroupK }
import org.scalacheck.{ Arbitrary, Cogen, Gen }
import zio.interop.catz._
import zio.{ IO, _ }
import zio._

class catzSpec extends catzSpecZIOBase {

Expand All @@ -28,7 +28,7 @@ class catzSpec extends catzSpecZIOBase {
checkAllAsync("MonadError[IO[Int, *]]", implicit tc => MonadErrorTests[IO[Int, *], Int].monadError[Int, Int, Int])
checkAllAsync("MonoidK[IO[Int, *]]", implicit tc => MonoidKTests[IO[Int, *]].monoidK[Int])
checkAllAsync("SemigroupK[IO[Option[Unit], *]]", implicit tc => SemigroupKTests[IO[Option[Unit], *]].semigroupK[Int])
checkAllAsync("SemigroupK[Task]", implicit tc => SemigroupKTestsOverrides[Task].semigroupK[Int])
checkAllAsync("SemigroupK[Task]", implicit tc => SemigroupKTests[Task].semigroupK[Int])
checkAllAsync("Bifunctor[IO]", implicit tc => BifunctorTests[IO].bifunctor[Int, Int, Int, Int, Int, Int])
checkAllAsync("Parallel[Task]", implicit tc => ParallelTests[Task, ParIO[Any, Throwable, *]].parallel[Int, Int])
checkAllAsync("Monad[UIO]", { implicit tc =>
Expand Down Expand Up @@ -151,30 +151,11 @@ trait AsyncLawsOverrides[F[_]] extends AsyncLaws[F] {

}

trait BracketLawsOverrides[F[_], E] extends BracketLaws[F, E] {}

trait ConcurrentLawsOverrides[F[_]] extends ConcurrentLaws[F] {}

trait SemigroupKLawsOverrides[F[_]] extends SemigroupKLaws[F] {}

trait ConcurrentEffectLawsOverrides[F[_]] extends ConcurrentEffectLaws[F] {}

object SemigroupKTestsOverrides {

def apply[F[_]](implicit ev: SemigroupK[F]): SemigroupKTests[F] =
new SemigroupKTests[F] {
def laws: SemigroupKLaws[F] = new SemigroupKLawsOverrides[F] {
override implicit def F: SemigroupK[F] = ev
}
}

}

object EffectTestsOverrides {

def apply[F[_]](implicit ev: Effect[F]): EffectTests[F] =
new EffectTests[F] {
def laws: EffectLaws[F] = new EffectLaws[F] with AsyncLawsOverrides[F] with BracketLawsOverrides[F, Throwable] {
def laws: EffectLaws[F] = new EffectLaws[F] with AsyncLawsOverrides[F] {
override val F: Effect[F] = ev
}
}
Expand All @@ -185,7 +166,7 @@ object ConcurrentTestsOverrides {
def apply[F[_]](implicit ev: Concurrent[F], cs: ContextShift[F]): ConcurrentTests[F] =
new ConcurrentTests[F] {
def laws: ConcurrentLaws[F] =
new ConcurrentLawsOverrides[F] with AsyncLawsOverrides[F] with BracketLawsOverrides[F, Throwable] {
new ConcurrentLaws[F] with AsyncLawsOverrides[F] {
override val F: Concurrent[F] = ev
override val contextShift: ContextShift[F] = cs
}
Expand All @@ -197,10 +178,7 @@ object ConcurrentEffectTestsOverrides {
def apply[F[_]](implicit ev: ConcurrentEffect[F], cs: ContextShift[F]): ConcurrentEffectTests[F] =
new ConcurrentEffectTests[F] {
def laws: ConcurrentEffectLaws[F] =
new ConcurrentEffectLawsOverrides[F]
with AsyncLawsOverrides[F]
with BracketLawsOverrides[F, Throwable]
with ConcurrentLawsOverrides[F] {
new ConcurrentEffectLaws[F] with AsyncLawsOverrides[F] {
override val F: ConcurrentEffect[F] = ev
override val contextShift: ContextShift[F] = cs
}
Expand Down