Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate unique runtime configs per webdriverio execution #77

Merged
merged 2 commits into from
Apr 4, 2018

Conversation

zinserjan
Copy link
Owner

Webdriverio's test runner does not provide any api to pass data from launcher to runner processes for custom services. #66 used a workaround to pass the data to the child process with a temporary file like suggested in webdriverio/webdriverio#1914. But the name of the file was fixed and leads to wrong results when running multiple instances of webdriverio at the same time.

This PR improves the workaround and avoids conflicts when you run several instances of webdriverio simultaneously.

Running simultaneously the same config file requires a Node version with at least 6.13.0, 8.10.0, 9.2.0. In previous versions process.ppid isn't available. But this should be a edge case (maybe a wdio config that is configured via environment variables?).

Changes:

  • move runtime config logic to BaseCompare -> every plugin can use this
  • further calls to read the config are cached
  • build a "unique" filename per webdriverio execution on the basis of the provided cli arguments and when available the process id.

@zinserjan zinserjan merged commit 6ecc8f0 into master Apr 4, 2018
@zinserjan zinserjan deleted the exchange-data branch April 4, 2018 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant