Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Mocha 5 as peerDependency #204

Merged
merged 4 commits into from
Mar 16, 2018
Merged

Conversation

astorije
Copy link
Contributor

@astorije astorije commented Feb 2, 2018

I have been using Mocha 5 + mocha-webpack 1.0.1 successfully on thelounge/thelounge#1726, so I think support for it can be endorsed.

This effectively suppresses the following warning at install time:

npm WARN [email protected] requires a peer of mocha@^2.4.5 || ^3.0.0 || ^4.0.0 but none was installed.

I have been using Mocha 5 + `mocha-webpack` 1.0.1 successfully on thelounge/thelounge#1726, so I think support for it can be endorsed.
@codecov-io
Copy link

codecov-io commented Feb 2, 2018

Codecov Report

Merging #204 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #204   +/-   ##
=======================================
  Coverage   96.77%   96.77%           
=======================================
  Files          28       28           
  Lines         744      744           
=======================================
  Hits          720      720           
  Misses         24       24

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9d99a0...97c09aa. Read the comment docs.

@astorije
Copy link
Contributor Author

@zinserjan, would you be able to look at this PR, and make a release if you're okay with it?
At the moment, mocha-webpack + Mocha v5 + Node.js v4 (still LTS for a few months) breaks npm install 😢
(More accurately, npm that comes with Node.js v4 and not directly Node.js v4, but the outcome is the same)

astorije added 2 commits March 9, 2018 00:23
Between the versions of Node, Mocha, and Webpack, there are now quite a lot of combinations, but {,un}fortunately this will be reduced with Webpack v4 support as it's likely it will be the only version of Webpack supported.
@astorije
Copy link
Contributor Author

astorije commented Mar 9, 2018

The failure on Travis is due to a missing peer dependencies with Node v4. I would ignore this because Node v4 is dropped by supporting Webpack v4. It can also be resolved by upgrading bdd-lazy-var, but I don't want to introduce too many unrelated changes in this PR. Happy to bump bdd-lazy-var in another PR though. EDIT: Nevermiiiind, npm is unhappy so bumping it.

@zinserjan
Copy link
Owner

Thanks, will publish this asap!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants