-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Mocha 5 as peerDependency #204
Conversation
I have been using Mocha 5 + `mocha-webpack` 1.0.1 successfully on thelounge/thelounge#1726, so I think support for it can be endorsed.
Codecov Report
@@ Coverage Diff @@
## master #204 +/- ##
=======================================
Coverage 96.77% 96.77%
=======================================
Files 28 28
Lines 744 744
=======================================
Hits 720 720
Misses 24 24 Continue to review full report at Codecov.
|
@zinserjan, would you be able to look at this PR, and make a release if you're okay with it? |
Between the versions of Node, Mocha, and Webpack, there are now quite a lot of combinations, but {,un}fortunately this will be reduced with Webpack v4 support as it's likely it will be the only version of Webpack supported.
The failure on Travis is due to a missing peer dependencies with Node v4. |
Thanks, will publish this asap! |
I have been using Mocha 5 +
mocha-webpack
1.0.1 successfully on thelounge/thelounge#1726, so I think support for it can be endorsed.This effectively suppresses the following warning at install time: