Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): wrap all subscription errors in QueryResults #768

Merged
merged 1 commit into from
Nov 9, 2020

Conversation

micimize
Copy link
Collaborator

@micimize micimize commented Nov 9, 2020

Closes #755 by wrapping all errors thrown in subscribe

@codecov
Copy link

codecov bot commented Nov 9, 2020

Codecov Report

Merging #768 (aae61ca) into beta (7eb3f58) will increase coverage by 0.18%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##             beta     #768      +/-   ##
==========================================
+ Coverage   49.29%   49.48%   +0.18%     
==========================================
  Files          35       35              
  Lines        1349     1354       +5     
==========================================
+ Hits          665      670       +5     
  Misses        684      684              
Flag Coverage Δ
graphql_client 52.75% <71.42%> (+0.20%) ⬆️
graphql_flutter 31.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/graphql/lib/src/core/query_manager.dart 66.17% <71.42%> (+1.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7eb3f58...aae61ca. Read the comment docs.

@micimize micimize merged commit 7e8d300 into beta Nov 9, 2020
@micimize micimize deleted the sub_handling branch November 9, 2020 15:50
@HofmannZ
Copy link
Member

🎉 This PR is included in version 4.0.0-beta.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@micimize
Copy link
Collaborator Author

@all-contributors please add micimize for ideas, doc, content, code, bug, example, infra, maintenance, projectManagement, question, review, test, tutorial

@allcontributors
Copy link
Contributor

@micimize

I've put up a pull request to add @micimize! 🎉

@HofmannZ
Copy link
Member

🎉 This PR is included in version 4.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subscription stream transformer missing
2 participants