-
-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgraded connectivity_plus package #1424
feat: upgraded connectivity_plus package #1424
Conversation
looks like that needs a rebase, please ping me when the conflict are fixed |
there is a conflict in pubspec file
which can be resolved when someone merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not use merge commit inside the PR, so you should rebase it with git rebase
.
This commit can be removed dee9b94
In addition, I left a couple of comments because I am a little bit confused while looking at your commit history
I think just the first one is what we want to merge?
@vincenzopalazzo any chance of getting this merged and released quickly if I fork this PR and submit an updated version? This is creating an unnecessary roadblock for projects that use both |
Any updates? |
@Avinash-dhiraj @vincenzopalazzo please check this |
This is unresolved #1424 (review) I have nothing to check |
Closing because looks like that there is already a fix #1423 (comment) Please open a new PR with a good git history if the problem persit |
upgraded connectivity_plus from 5.0.0 to 6.0.2
Please merge this on priority as this breaking changes is needed for all the flutter application which is using connectivity_plus 6.0.2 along with graphql_flutter
Fixes #1423 (comment)