Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgraded connectivity_plus package #1424

Conversation

Avinash-dhiraj
Copy link

@Avinash-dhiraj Avinash-dhiraj commented Apr 12, 2024

  • As app store introduced mandatory privacy manifest files for some of packages being used in the application. connectivity_plus 6.0.2 is one of them and current version of connectivity_plus 6.0.2 has added support for privacy manifest but graphql_flutter still using connectivity_plus 5.0.0 which leads into compatibility issue. App store is very specific about the deadline of these as well which is 1st of may.;

upgraded connectivity_plus from 5.0.0 to 6.0.2

Please merge this on priority as this breaking changes is needed for all the flutter application which is using connectivity_plus 6.0.2 along with graphql_flutter

Fixes #1423 (comment)

@Avinash-dhiraj Avinash-dhiraj changed the title docs: upgraded connectivity_plus package feat: upgraded connectivity_plus package Apr 12, 2024
@vincenzopalazzo
Copy link
Collaborator

looks like that needs a rebase, please ping me when the conflict are fixed

@vincenzopalazzo vincenzopalazzo self-requested a review April 12, 2024 21:29
@Avinash-dhiraj
Copy link
Author

Avinash-dhiraj commented Apr 13, 2024

looks like that needs a rebase, please ping me when the conflict are fixed

there is a conflict in pubspec file

<<<<<<< connectivity-plus-upgrade
  connectivity_plus: ^6.0.2
=======
  connectivity_plus: ^5.0.0
>>>>>>> main

<<<<<<< connectivity-plus-upgrade
  sdk: '>=3.3.0 <=4.0.0'
  flutter: ">=3.19.5"
=======
  sdk: '>=2.12.0 <4.0.0'
  flutter: ">=2.11.0"
>>>>>>> main

which can be resolved when someone merge it.

Copy link
Collaborator

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not use merge commit inside the PR, so you should rebase it with git rebase.

This commit can be removed dee9b94

In addition, I left a couple of comments because I am a little bit confused while looking at your commit history

I think just the first one is what we want to merge?

packages/graphql_flutter/pubspec.yaml Outdated Show resolved Hide resolved
packages/graphql_flutter/pubspec.yaml Outdated Show resolved Hide resolved
@johnmartel
Copy link
Contributor

@vincenzopalazzo any chance of getting this merged and released quickly if I fork this PR and submit an updated version? This is creating an unnecessary roadblock for projects that use both graphql_flutter and connectivity_plus that want to upgrade their dependencies.

@selawik
Copy link

selawik commented May 3, 2024

Any updates?

@SachinCodeMatrix
Copy link

@Avinash-dhiraj @vincenzopalazzo please check this

@vincenzopalazzo
Copy link
Collaborator

This is unresolved #1424 (review)

I have nothing to check

@vincenzopalazzo vincenzopalazzo self-requested a review September 11, 2024 09:34
@vincenzopalazzo
Copy link
Collaborator

Closing because looks like that there is already a fix #1423 (comment)

Please open a new PR with a good git history if the problem persit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please add support for connectivity_plus 6.0.2
5 participants